Skip to content

fix(react): use pickup location address for tax calculation on billing updates#1355

Merged
wcole1-godaddy merged 3 commits intogodaddy:mainfrom
nlaverde-godaddy:vnext-78469
Apr 21, 2026
Merged

fix(react): use pickup location address for tax calculation on billing updates#1355
wcole1-godaddy merged 3 commits intogodaddy:mainfrom
nlaverde-godaddy:vnext-78469

Conversation

@nlaverde-godaddy
Copy link
Copy Markdown
Contributor

@nlaverde-godaddy nlaverde-godaddy commented Apr 20, 2026

Summary

When a customer selects in-person pickup and edits their billing address (even just deleting and re-typing a digit), the tax calculation was using the wrong address, resulting in incorrect tax amounts.

#Root cause
Root Cause: Inuse-update-order.ts, when the billing address was updated, updateTaxes.mutate() was called with undefined, causing the backend to use the customer's billing address instead of the pickup location address for tax calculation.

Example of the bug:

Pickup location zipcode: 30143 (7% tax rate)
Customer billing zipcode: 30734 (8% tax rate)
First calculation: Correctly uses pickup location → 7% ✅
After editing billing address: Uses customer address → 8% ❌ (now fixed)
Related ticket: https://godaddy-corp.atlassian.net/browse/CIEC-11081

Changeset

  • Changeset added (docs)

Test Plan

Test Plan
Unit Tests (9 new tests):

✅ Returns pickup location address for PICKUP delivery method
✅ Returns correct location when multiple locations exist
✅ Returns undefined if pickup location not found
✅ Returns undefined if locations array is empty
✅ Returns undefined if locations is undefined
✅ Returns undefined for SHIP delivery method
✅ Returns undefined when delivery method is undefined
✅ Handles pickupLocationId being undefined for pickup
✅ Handles empty string pickupLocationId for pickup

Screenshot 2026-04-20 at 12 19 47

@nlaverde-godaddy nlaverde-godaddy requested a review from a team as a code owner April 20, 2026 17:14
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 20, 2026

🦋 Changeset detected

Latest commit: 472bd02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@godaddy/react Patch
nextjs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Collaborator

@pbennett1-godaddy pbennett1-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch!

@wcole1-godaddy wcole1-godaddy merged commit 815fa6c into godaddy:main Apr 21, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants